test: use on-disk fixture for test-npm-install#62584
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Apr 7, 2026
Merged
test: use on-disk fixture for test-npm-install#62584nodejs-github-bot merged 1 commit intonodejs:mainfrom
nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Instead of writing the fixtures on the fly in the test, put them in the fixtures directory that can be copied into a temporary directory to reproduce in a debugger. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62584 +/- ##
==========================================
- Coverage 89.72% 89.71% -0.01%
==========================================
Files 695 695
Lines 214464 214464
Branches 41067 41060 -7
==========================================
- Hits 192420 192400 -20
- Misses 14106 14116 +10
- Partials 7938 7948 +10 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Apr 4, 2026
github-actions
bot
removed
the
request-ci
Collaborator
legendecas
approved these changes
Apr 5, 2026
Collaborator
legendecas
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in f48ac91 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of writing the fixtures on the fly in the test, put them in the fixtures directory that can be copied into a temporary directory to reproduce in a debugger.
Refs: #61898